Skip to content

fix(solana): listen on wallet's accountChanged - #5921

Merged
guanbinrui merged 6 commits into
developfrom
fix/phantom-switch
Mar 23, 2022
Merged

fix(solana): listen on wallet's accountChanged#5921
guanbinrui merged 6 commits into
developfrom
fix/phantom-switch

Conversation

@UncleBill

@UncleBill UncleBill commented Mar 22, 2022

Copy link
Copy Markdown
Contributor

closes #MF-77

@github-actions

github-actions Bot commented Mar 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://623ac2324f3e507df7dea151--compassionate-northcutt-326a3a.netlify.app

@github-actions
github-actions Bot temporarily deployed to pull request March 22, 2022 08:00 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request March 22, 2022 12:36 Inactive
UncleBill
UncleBill commented Mar 23, 2022
View reviewed changes
Comment thread packages/injected-script/main/GlobalVariableBridge/index.ts Outdated
@github-actions
github-actions Bot temporarily deployed to pull request March 23, 2022 02:59 Inactive
guanbinrui
guanbinrui reviewed Mar 23, 2022
View reviewed changes
Comment thread packages/plugins/Solana/src/wallet/connect.ts Outdated
guanbinrui
guanbinrui reviewed Mar 23, 2022
View reviewed changes
Comment thread packages/plugins/Solana/src/storage/index.ts Outdated
Lanttcat
Lanttcat reviewed Mar 23, 2022
View reviewed changes
Comment thread packages/injected-script/main/GlobalVariableBridge/index.ts Outdated
guanbinrui
guanbinrui reviewed Mar 23, 2022
View reviewed changes
Comment thread packages/plugins/Solana/src/wallet/connect.ts
guanbinrui
guanbinrui reviewed Mar 23, 2022
View reviewed changes
Comment thread packages/plugins/Solana/src/wallet/connect.ts
@github-actions
github-actions Bot temporarily deployed to pull request March 23, 2022 03:38 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request March 23, 2022 04:13 Inactive
guanbinrui
guanbinrui reviewed Mar 23, 2022
View reviewed changes
Comment thread packages/plugins/Solana/src/storage/index.ts Outdated
Comment thread packages/plugins/Solana/src/wallet/connect.ts
@github-actions
github-actions Bot temporarily deployed to pull request March 23, 2022 06:46 Inactive
guanbinrui
guanbinrui approved these changes Mar 23, 2022
View reviewed changes

@guanbinrui guanbinrui left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @DimensionDev/qa

@AinuX

AinuX commented Mar 23, 2022

Copy link
Copy Markdown
Collaborator

Checked

@guanbinrui
guanbinrui merged commit 2c7f22a into develop Mar 23, 2022
@guanbinrui
guanbinrui deleted the fix/phantom-switch branch March 23, 2022 07:50
@guanbinrui guanbinrui mentioned this pull request Mar 23, 2022
Merged
nuanyang233 pushed a commit to layinka/Maskbook that referenced this pull request Mar 28, 2022
@UncleBill @nuanyang233
fix(solana): listen on wallet's accountChanged (DimensionDev#5921)
9f8e192 
* fix(solana): listen on wallet's accountChanged

closes #MF-77

* fix: initial connect

* Update packages/injected-script/main/GlobalVariableBridge/index.ts

* fix: storage.network => storage.chainId

* fix: watch disconnect by the way

* fix: use enum ChainId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes
@Lanttcat Lanttcat Awaiting requested review from Lanttcat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UncleBill @AinuX @Lanttcat @guanbinrui